Idan Shaby has uploaded a new change for review. Change subject: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType ......................................................................
core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ish...@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/34865/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java index 3e48433..8df6777 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java @@ -22,8 +22,8 @@ public class StorageDomainDAODbFacadeImpl extends BaseDAODbFacade implements StorageDomainDAO { @Override - public Guid getMasterStorageDomainIdForPool(Guid pool) { - return getStorageDomainIdForPoolByType(pool, StorageDomainType.Master); + public Guid getMasterStorageDomainIdForPool(Guid poolId) { + return getStorageDomainId(poolId, StorageDomainType.Master); } @Override @@ -36,8 +36,8 @@ } @Override - public Guid getIsoStorageDomainIdForPool(Guid pool) { - return getStorageDomainIdForPoolByType(pool, StorageDomainType.ISO); + public Guid getIsoStorageDomainIdForPool(Guid poolId) { + return getStorageDomainId(poolId, StorageDomainType.ISO); } @Override @@ -213,15 +213,15 @@ } /** - * Gets the storage domain id of the given type for the given storage pool + * Gets the storage domain id of the given type for the given storage pool id. * - * @param pool - * @param type - * @return + * @param poolId The storage pool id, + * @param type The storage domain type. + * @return the storage domain id of the given type for the given storage pool id. */ - private Guid getStorageDomainIdForPoolByType(Guid pool, StorageDomainType type) { + private Guid getStorageDomainId(Guid poolId, StorageDomainType type) { Guid returnValue = Guid.Empty; - StorageDomain domain = getStorageDomain(pool, type); + StorageDomain domain = getStorageDomain(poolId, type); if (domain != null) { returnValue = domain.getId(); } -- To view, visit http://gerrit.ovirt.org/34865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ish...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
