Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: marshalling of Long type ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34854/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 280: Line 281: @Override Line 282: protected ReqWriter newReqWriter(XmlRpcRequest pRequest) Line 283: throws XmlRpcException, IOException, SAXException { Line 284: if (METHOD_LIST.contains(pRequest.getMethodName())) { > .contains on a List is not really effective. What about using a Set instead There will be difference when there is a lot of elements in collection. I suspect that we do not have as many elements. Using HashSet will be more effective so I will update. Line 285: pRequest = Line 286: new XmlRpcClientRequestImpl(pRequest.getConfig(), Line 287: pRequest.getMethodName(), Line 288: normalizeDoubles(pRequest)); Line 289: } Line 290: return super.newReqWriter(pRequest); Line 291: } Line 292: Line 293: private Object[] normalizeDoubles(XmlRpcRequest request) { > normalizeLongs? Done Line 294: List<Object> result = new ArrayList<>(); Line 295: for (int i = 0; i < request.getParameterCount(); i++) { Line 296: Object object = request.getParameter(i); Line 297: if (Long.class.isInstance(object)) { -- To view, visit http://gerrit.ovirt.org/34854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97ffc2da3703dbf7ce58607b7461a02aea35f2bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
