Allon Mureinik has posted comments on this change. Change subject: core: Add a CDA on attach to an uninitialized Data Center ......................................................................
Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/34239/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 453: } Line 454: return returnValue; Line 455: } Line 456: Line 457: private boolean isDomainAttachedToDifferentDataCenter() { s/DataCenter/StoragePool Line 458: List<StorageDomain> storageDomainList = Line 459: (List<StorageDomain>) getBackend().runInternalQuery(VdcQueryType.GetStorageDomainsWithAttachedStoragePoolGuid, Line 460: new StorageDomainsAndStoragePoolIdQueryParameters(getStorageDomain(), getStoragePoolId())).getReturnValue(); Line 461: return !storageDomainList.isEmpty(); -- To view, visit http://gerrit.ovirt.org/34239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaba522270660aaf2b58e7e771e31c9084824076f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
