Alon Bar-Lev has posted comments on this change. Change subject: aaa: provide UI error for builtin krbldap ......................................................................
Patch Set 1: (2 comments) nice! few comments. http://gerrit.ovirt.org/#/c/34852/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java: Line 17: import org.ovirt.engine.api.extensions.aaa.Authz.QueryFilterRecord; Line 18: import org.ovirt.engine.core.common.businessentities.aaa.LdapGroup; Line 19: import org.ovirt.engine.core.common.businessentities.aaa.LdapUser; Line 20: Line 21: remove from patch ? Line 22: /** Line 23: * This directory implementation is a bridge between the new directory interfaces and the existing LDAP infrastructure. Line 24: * It will exist only while the engine is migrated to use the new directory interfaces, then it will be removed. Line 25: */ Line 357: } Line 358: return result; Line 359: } Line 360: Line 361: public void checkForErrors(LdapReturnValueBase ldapResult, ExtMap output) { won't it better to throw an exception? I think that the top level has catch which does exactly that. Line 362: if (!ldapResult.getSucceeded()) { Line 363: output.mput( Line 364: Base.InvokeKeys.RESULT, Base.InvokeResult.FAILED Line 365: ).mput( -- To view, visit http://gerrit.ovirt.org/34852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
