Allon Mureinik has posted comments on this change. Change subject: webadmin: Add a warning when detaching a Storage Domain ......................................................................
Patch Set 8: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/34090/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java: Line 497: boolean shouldAddressWarnning = false; Line 498: for (StorageDomain item : Linq.<StorageDomain> cast(getSelectedItems())) { Line 499: list.add(item.getStorageName()); Line 500: if (item.getStorageDomainType() == StorageDomainType.Data || Line 501: item.getStorageDomainType() == StorageDomainType.Master) { please use item.getStorageDomainType().isDataDomain() Line 502: shouldAddressWarnning = true; Line 503: } Line 504: } Line 505: model.setItems(list); Line 498: for (StorageDomain item : Linq.<StorageDomain> cast(getSelectedItems())) { Line 499: list.add(item.getStorageName()); Line 500: if (item.getStorageDomainType() == StorageDomainType.Data || Line 501: item.getStorageDomainType() == StorageDomainType.Master) { Line 502: shouldAddressWarnning = true; once you set shouldAddressWarnning to true you should break - there's no point continuing to iterate. Line 503: } Line 504: } Line 505: model.setItems(list); Line 506: http://gerrit.ovirt.org/#/c/34090/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java: Line 433: for (Object item : getSelectedItems()) Line 434: { Line 435: StorageDomain a = (StorageDomain) item; Line 436: items.add(a.getStoragePoolName()); Line 437: if (a.getStorageDomainType() == StorageDomainType.Data) { please use a.getStorageDomainType().isDataDomain() Line 438: shouldAddressWarnning = true; Line 439: } Line 440: } Line 441: model.setItems(items); Line 434: { Line 435: StorageDomain a = (StorageDomain) item; Line 436: items.add(a.getStoragePoolName()); Line 437: if (a.getStorageDomainType() == StorageDomainType.Data) { Line 438: shouldAddressWarnning = true; once you set shouldAddressWarnning to true you should break - there's no point continuing to iterate. Line 439: } Line 440: } Line 441: model.setItems(items); Line 442: -- To view, visit http://gerrit.ovirt.org/34090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id18794fe37e9c3717fa37abac5bf69a928c800c9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
