Allon Mureinik has posted comments on this change. Change subject: webadmin: Date formatting when deleting a snapshot ......................................................................
Patch Set 1: Code-Review-1 (3 comments) See comments inline. On a more general point - why have this patch introduce a constant and then move it in another patch? Why not just introduce it in the right place to begin with? http://gerrit.ovirt.org/#/c/34837/1//COMMIT_MSG Commit Message: Line 8: Line 9: When deleting a VM's snapshot a formatted date is now shown based on a Line 10: constant taken from another component in the system (DiskGeneralModel) Line 11: for system consistency. this constant is intended to be exported to Line 12: some UTILS class later on. s/UTILS/util/ Line 13: Line 14: Bug-Url: https://bugzilla.redhat.com/1158959 Line 15: Line 16: Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Line 11: for system consistency. this constant is intended to be exported to Line 12: some UTILS class later on. Line 13: Line 14: Bug-Url: https://bugzilla.redhat.com/1158959 Line 15: Plesse remove the blank line. Having it will mean that the Bug-Url is not part of the footer. Line 16: Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba http://gerrit.ovirt.org/#/c/34837/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java: Line 52: @SuppressWarnings("unused") Line 53: public class VmSnapshotListModel extends SearchableListModel Line 54: { Line 55: // This constant is intendend to be exported to a generic UTILS class later on Line 56: private final String DATE_FORMAT = "yyyy-MM-dd, HH:mm"; //$NON-NLS-1$ should be static. Line 57: Line 58: private UICommand privateNewCommand; Line 59: Line 60: public UICommand getNewCommand() { -- To view, visit http://gerrit.ovirt.org/34837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
