Martin Betak has posted comments on this change. Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed properties ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/32133/8/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HierarchicalBoolean.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HierarchicalBoolean.java: Line 2: Line 3: import org.apache.commons.lang.StringUtils; Line 4: Line 5: public enum HierarchicalBoolean { Line 6: TRUE, FALSE, INHERIT; > Would be nice to have a comment here what "inherit" means. If I understand Done Line 7: Line 8: public String value() { Line 9: return name().toLowerCase(); Line 10: } -- To view, visit http://gerrit.ovirt.org/32133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9161896d1709c7492201667aa2c5955c5e37efd0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
