Yair Zaslavsky has posted comments on this change. Change subject: engine : Set endAction try again to false on failure ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34702/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 648: if (hasTaskHandlers()) { Line 649: if (hasStepsToRevert()) { Line 650: getCurrentTaskHandler().endWithFailure(); Line 651: revertPreviousHandlers(); Line 652: } else { based on your commit msg, shouldn't this be at the else of if (hasTaskHandlers()) ? Line 653: // since no handlers have been run we don't have to retry endAction Line 654: getReturnValue().setEndActionTryAgain(false); Line 655: } Line 656: startPollingAsyncTasks(); -- To view, visit http://gerrit.ovirt.org/34702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
