Shahar Havivi has posted comments on this change. Change subject: RFE: sysprep file name should be according to its version ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/34785/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java: Line 154: * @param osId Line 155: * @param version Line 156: * @return Line 157: */ Line 158: public String getSysprepDestName(int osId, Version version); > can you propose a better name for that field and method? ok, I will change it to sysprepFile Line 159: Line 160: /** Line 161: * this Windows OSs specific product key Line 162: * @param osId http://gerrit.ovirt.org/#/c/34785/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java: Line 388: } Line 389: Line 390: @Override Line 391: public String getSysprepDestName(int osId, Version version) { Line 392: return EngineLocalConfig.getInstance().expandString(getValueByVersion(idToUnameLookup.get(osId), "sysprepDestName", version)); > does this file can have VARIABLES? just need to know why use expandString. No, This is a static name Line 393: } Line 394: Line 395: @Override Line 396: public String getProductKey(int osId, Version version) { -- To view, visit http://gerrit.ovirt.org/34785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
