Lev Veyde has posted comments on this change. Change subject: packaging: setup: Add ISO and VFD uploading plugin ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/34760/2/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 429: ) Line 430: def REMOTE_ENGINE_HOST_ROOT_PASSWORD(self): Line 431: return 'OVESETUP_CONFIG/remoteEngineHostRootPassword' Line 432: Line 433: ISO_PATHS_TO_UPLOAD = 'isoPathsToUpload' > Please add a prefix: Done Line 434: Line 435: Line 436: @util.export Line 437: @util.codegen http://gerrit.ovirt.org/#/c/34760/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py: Line 57: @plugin.event( Line 58: stage=plugin.Stages.STAGE_SETUP, Line 59: ) Line 60: def _setup(self): Line 61: self.environment[osetupcons.ConfigEnv.ISO_PATHS_TO_UPLOAD] = [ > perhaps extend and not replace? Need to think about this. Generally the basic files to load are quite constant, so if anyone wants this to be modifiable it will probably be in order to upload some additional ISOs. Thus it's better to be implemented as another option, like EXTRA_ISO_PATHS_TO_UPLOAD, so the user won't be required to list the standard ones. Nice idea though. Line 62: os.path.join( Line 63: osetupcons.FileLocations.VIRTIO_WIN_DIR, Line 64: 'virtio-win_x86.vfd', Line 65: ), -- To view, visit http://gerrit.ovirt.org/34760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b5c4ab5a16bf56c4b77b40bb76080d9420eede Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
