Tal Nisan has posted comments on this change. Change subject: core: Check live snapshot capabilities in live storage migration CDA ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/34612/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/LiveSnapshotHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/LiveSnapshotHelper.java: Line 6: import org.ovirt.engine.core.common.config.ConfigValues; Line 7: import org.ovirt.engine.core.common.errors.VdcBllMessages; Line 8: import org.ovirt.engine.core.compat.Version; Line 9: Line 10: public class LiveSnapshotHelper { > how about rename it to LiveSnapshotValidator to conform the convention and Possible given the current content of this class but the general idea was to use it as a helper and include more helper methods here in the future. For now we can do either way, what do you think? I have no strong opinion either way Line 11: Line 12: public static ValidationResult canDoSnapshot(Version compatibilityVersion, VDS vds) { Line 13: if (!isLiveSnapshotEnabled(compatibilityVersion)) { Line 14: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DATA_CENTER_VERSION_DOESNT_SUPPORT_LIVE_SNAPSHOT); -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
