Daniel Erez has posted comments on this change. Change subject: restapi: OpenStack image provider ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/33975/6/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderHelper.java: Line 37: */ Line 38: public static Guid getStorageDomainId(BackendResource resource, String providerId) { Line 39: // The backend doesn't have any mechanism to obtain the images other than listing the images provided by the Line 40: // storage domain that is created for the provider, and the only way to find that provider is to iterate the Line 41: // complete list. This is potentially very slow, so it should be improved in the future. > There is no query corresponding to getAllByConnectionId, and the RESTAPI sh Of course, I just said we should add a simple query for it later on... Line 42: Guid storageDomainId = null; Line 43: List<StorageDomain> storageDomains = Line 44: resource.runQuery(VdcQueryType.GetAllStorageDomains, new VdcQueryParametersBase()).getReturnValue(); Line 45: for (StorageDomain storageDomain : storageDomains) { -- To view, visit http://gerrit.ovirt.org/33975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77fca2208b18d54f9177ec8b0178768a6b815f20 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
