Allon Mureinik has posted comments on this change. Change subject: core: add ability to run shell upgrade steps ......................................................................
Patch Set 2: (2 inline comments) I'm not sure I understand this patch - where is the defrentiation on how to differently run .sh and .sql scritps? .................................................... File backend/manager/dbscripts/dbfunctions.sh Line 191: echo ${sqlFiles} " " ${shFiles} I think this is a debug printing you forgot here. .................................................... Commit Message Line 14: upgrade scripts (extension is .sh) and recorded in the same way to the s/and recorder/and are recorded/ -- To view, visit http://gerrit.ovirt.org/6957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3a88c21c97ebdd9bd35c2b0da87cba1cbde54c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches