Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: Move ManagementNetworkUtil to vdsbroker module ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/33902/16/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java: Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.network.Network; Line 4: import org.ovirt.engine.core.compat.Guid; Line 5: Line 6: // TODO: move the interface to more suitable for that module as soon as it will be possible (CDI cross module issue > Why not moving it to Utils? I'd prefer to keep this interface visibility as low as possible. Ideally it should be used by bll only and reside there, however currently it is used by vdsbroker code too. As soon as the vdsbroker will be cleaned from the business logic that relies on this interface it should be moved to bll module. Putting it in util would enable adding more business logic out of bll module. IMHO that the cleanest way out of the all durty ones. Line 7: // is solved). Line 8: public interface ManagementNetworkUtil { Line 9: Line 10: /** -- To view, visit http://gerrit.ovirt.org/33902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a70445e672ca88ce425fb89702cf0360dcd67 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
