Alexander Wels has uploaded a new change for review. Change subject: webadmin: Main tab presenter loading ......................................................................
webadmin: Main tab presenter loading - When clicking a main tab right after login the application would load the code fragments for all main tabs instead of just the one you clicked on. This patch fixes that issue and only the tab you selected is loaded. Change-Id: I63695ad15cbd5633bb081f2f031fb31743886c14 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155992 Signed-off-by: Alexander Wels <aw...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/34707/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java index 7a924ad..f636fe6 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java @@ -8,7 +8,6 @@ import com.google.gwt.event.shared.EventBus; import com.gwtplatform.mvp.client.View; -import com.gwtplatform.mvp.client.annotations.ProxyEvent; import com.gwtplatform.mvp.client.proxy.PlaceManager; import com.gwtplatform.mvp.client.proxy.PlaceRequest; import com.gwtplatform.mvp.client.proxy.TabContentProxyPlace; @@ -25,7 +24,9 @@ * @param <P> * Proxy type. */ -public abstract class AbstractMainTabPresenter<T, M extends SearchableListModel, V extends View, P extends TabContentProxyPlace<?>> extends AbstractTabPresenter<V, P> { +public abstract class AbstractMainTabPresenter<T, M extends SearchableListModel, V extends View, + P extends TabContentProxyPlace<?>> extends AbstractTabPresenter<V, P> + implements MainModelSelectionChangeEvent.MainModelSelectionChangeHandler { protected final PlaceManager placeManager; protected final MainModelProvider<T, M> modelProvider; @@ -71,7 +72,13 @@ return modelProvider.getModel(); } - @ProxyEvent + @Override + protected void onBind() { + super.onBind(); + registerHandler(getEventBus().addHandler(MainModelSelectionChangeEvent.getType(), this)); + } + + @Override public void onMainModelSelectionChange(MainModelSelectionChangeEvent event) { if (event.getMainModel() == getModel()) { if (event.getMainModel().getIsAvailable()) { -- To view, visit http://gerrit.ovirt.org/34707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63695ad15cbd5633bb081f2f031fb31743886c14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <aw...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
