Martin Peřina has posted comments on this change. Change subject: core: Remove usage of ExceptionUtils.getMessage ......................................................................
Patch Set 1: (2 comments) Btw, I don't see any other call of ExceptionUtils.getMessage even after rebase. I can see only calls of other methods like getRootCause or getRootCauseMessage http://gerrit.ovirt.org/#/c/34668/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 158: log.debug("Exception", ex); Line 159: try { Line 160: Thread.sleep(waitBetweenInterval); Line 161: } catch (InterruptedException e) { Line 162: log.warn("Failed to wait between connection polling attempts", e); > e.getMessage() and debug trace? IMHO it's important to have stacktrace logged always, because message won't tell all needed details Line 163: } Line 164: } Line 165: Line 166: } http://gerrit.ovirt.org/#/c/34668/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 428: } Line 429: Line 430: private void handleVdsLiveSnapshotFailure(VdcBLLException e) { Line 431: log.warn("Could not perform live snapshot due to error, VM will still be configured to the new created snapshot", Line 432: e); > getMessage() and debug trace? Added Line 433: addCustomValue("SnapshotName", getSnapshotName()); Line 434: addCustomValue("VmName", getVmName()); Line 435: updateCallStackFromThrowable(e); Line 436: AuditLogDirector.log(this, AuditLogType.USER_CREATE_LIVE_SNAPSHOT_FINISHED_FAILURE); -- To view, visit http://gerrit.ovirt.org/34668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113d01c167397456c0cc7b12a112971e482cf56d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
