ofri masad has posted comments on this change. Change subject: core: vds comparison with a drools ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsComparer.java Line 55: public abstract boolean isBetter(VDS x, VDS y, VM vm); It looks like a good place to add a method: public VDS getBest(List<VDS> vdss, VM vm) which compares couples of vds to find the best vds from a list. -- To view, visit http://gerrit.ovirt.org/6574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib25f90fab07b7c89830695dbb99120f8973da3cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
