Tomas Jelinek has posted comments on this change. Change subject: core: enable migration to a different cluster ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34316/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java: Line 24: Line 25: private VDSGroup targetCluster; Line 26: Line 27: public ChangeVmClusterValidator(VmCommand parentCommand, Guid targetClusterId) { Line 28: this.parentCommand = parentCommand; > right, but in the validator you should not call those methods. the validato after a discussion with Omer we came to conclusion that it would require to refactor also the AddVmCommand.checkCpuSockets, VmHandler.isUsbPolicyLegal, VmHandler.isDisplayTypeSupported, VmHandler.isOsTypeSupportedForVirtioScsi, VmDeviceUtils.isVirtioScsiControllerAttached and maybe something else and it would be out of scope of this patch. Also passing only the list of messages here would require to duplicate some logic from CommandBase (like valida()) and that is not a great idea. So we came to conclusion that this is the least possible evil for now, and than we can do a bigger cleanup later. Line 29: this.targetClusterId = targetClusterId; Line 30: } Line 31: Line 32: protected boolean validate() { -- To view, visit http://gerrit.ovirt.org/34316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eb4fd7f10d3b0e63455a81f0b5c1389586a43f4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
