Alexander Wels has posted comments on this change. Change subject: webadmin: readonly label editors ......................................................................
Patch Set 1: Hi Guys, In the patch that this one is dependent on, I introduced a new constructor for EntityModelLabelEditor that only takes a renderer and NOT a parser. This is meant only for READONLY fields. This has the advantage that you don't have to worry about parsing field values as they are not used anyway. I searched the code base for places I thought would be readonly fields which had a parser. Could you guys checkout if all the ones I modified are actually readonly. Thanks, Alexander -- To view, visit http://gerrit.ovirt.org/34615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d485f40d574df26ab4b4a0f6f60679e2c2b2506 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
