Vojtech Szocs has posted comments on this change. Change subject: webadmin: Simplify report redirect ......................................................................
Patch Set 9: Code-Review+1 (2 comments) GWT frontend part looks OK, just one small comment. http://gerrit.ovirt.org/#/c/33550/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java: Line 46: return URL.encode(value); Line 47: } Line 48: Line 49: /** Line 50: * Parse the parsed in URL, and take any parameters found and put them in this {@code HtmlParameters} object. ... passed in URL :-) Line 51: * This is a naive parse method. Line 52: * This will not handle duplicate parameters, nor empty ones, nor hash tags, or partials. Line 53: * So this will fail: ?a=b&c&d&e=f#g;h even though it is a valid URL. Line 54: * @param baseUrl The {@code String} URL to parse. http://gerrit.ovirt.org/#/c/33550/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java: Line 14: private boolean differntDcError = false; Line 15: private final String reportUrl; Line 16: Line 17: public ReportModel(String baseUrl, String ssoToken) { Line 18: reportUrl = baseUrl.indexOf('?') < 0 ? baseUrl : baseUrl.substring(0, baseUrl.indexOf('?')); Can we have some helper method to avoid complex / duplicate code? Line 19: paramsMap.parseUrlParams(baseUrl); Line 20: paramsMap.setParameter("sessionID", ssoToken); //$NON-NLS-1$ Line 21: paramsMap.setParameter("active_hosts_select", //$NON-NLS-1$ Line 22: "AND+delete_date+IS+NULL"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/33550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
