Ravi Nori has uploaded a new change for review. Change subject: engine : snapshot creation task is not polled by engine ......................................................................
engine : snapshot creation task is not polled by engine When the connectivity to storage domain is shutdown during live storage migration flow, the async tasks take a long time to clear after the connectivity wth storage domain has been restorted. This results in the VM disks being locked for a long time. Change-Id: I78cb581b9c6ef350070e5ad53396daa069b0b4ea Bug-Url: https://bugzilla.redhat.com/1078095 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/34602/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java index 7c7e3c5..56b2cbf 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java @@ -72,11 +72,13 @@ @Override public void endSuccessfully() { + enclosingCommand.getReturnValue().setEndActionTryAgain(false); } @Override public void endWithFailure() { enclosingCommand.getReturnValue().setSucceeded(true); + enclosingCommand.getReturnValue().setEndActionTryAgain(false); } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java index 8debf85..107468d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java @@ -80,6 +80,7 @@ } ExecutionHandler.endJob(enclosingCommand.getExecutionContext(), true); + enclosingCommand.getReturnValue().setEndActionTryAgain(false); } private void updateDestinationImageId(LiveMigrateDiskParameters parameters) { @@ -114,6 +115,7 @@ ExecutionHandler.endJob(enclosingCommand.getExecutionContext(), false); enclosingCommand.getReturnValue().setSucceeded(true); + enclosingCommand.getReturnValue().setEndActionTryAgain(false); } @Override -- To view, visit http://gerrit.ovirt.org/34602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I78cb581b9c6ef350070e5ad53396daa069b0b4ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
