Alona Kaplan has posted comments on this change. Change subject: engine: Add DefaultManagementNetworkFinder ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/33275/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinder.java: Line 9: * Finds the default management network for the given DC. Line 10: * Line 11: * @param dataCenterId Line 12: * data center id Line 13: * @returnthe default management {@link Network} space Line 14: */ Line 15: Network findDefaultManagementNetwork(Guid dataCenterId); Line 16: http://gerrit.ovirt.org/#/c/33275/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinderImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DefaultManagementNetworkFinderImpl.java: Line 25: Line 26: /** Line 27: * The algorithm for finding the default management network is: Line 28: * <ol> Line 29: * <li>Use the default management network (ovirtmgmt) if exists in the data center (for backward compatibility)</li> Don't use 'ovirtmgmt' name explicitly. You can write- Use the default management network as defined by <code>ConfigValues.DefaultManagementNetwork</code>. Line 30: * <li>If the data center has a single management network use that.</li> Line 31: * <li>Otherwise return <code>null</code></li> Line 32: * </ol> Line 33: * -- To view, visit http://gerrit.ovirt.org/33275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f8f0d53096523414ceb339d1b43224b540e0f78 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
