Martin Betak has posted comments on this change. Change subject: backend: Add support for auto-convergence and XBZRLE compression ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/32132/7/packaging/dbscripts/upgrade/03_06_0410_add_vm_auto_convergence.sql File packaging/dbscripts/upgrade/03_06_0410_add_vm_auto_convergence.sql: Line 1: SELECT fn_db_add_column('vm_static', 'is_auto_converge', 'BOOLEAN DEFAULT FALSE'); Line 2: SELECT fn_db_add_column('vm_static', 'is_migrate_compressed', 'BOOLEAN DEFAULT FALSE'); Line 3: Line 4: SELECT fn_db_add_column('vds_groups', 'is_auto_converge', 'BOOLEAN DEFAULT FALSE'); Line 5: SELECT fn_db_add_column('vds_groups', 'is_migrate_compressed', 'BOOLEAN DEFAULT FALSE'); > dont we want the defaults to be null? so the config will be used unless use thank you! this dbscript predates the decision to include hierarchical configuration, so it was simple boolean value back then http://gerrit.ovirt.org/#/c/32132/7/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 362: select fn_db_add_config_value('MigrationCompressionSupported','false','3.1'); Line 363: select fn_db_add_config_value('MigrationCompressionSupported','false','3.2'); Line 364: select fn_db_add_config_value('MigrationCompressionSupported','false','3.3'); Line 365: select fn_db_add_config_value('MigrationCompressionSupported','false','3.4'); Line 366: select fn_db_add_config_value('MigrationCompressionSupported','false','3.5'); > please add the defaults as well, so it could be updated by engine-config Well, these config values are specified in http://gerrit.ovirt.org/#/c/32132/7/packaging/etc/engine-config/engine-config.properties as usual. Line 367: Line 368: -- by default use no proxy Line 369: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 370: -- To view, visit http://gerrit.ovirt.org/32132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04a651c4a6995876742092be31ca6e3510194b31 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
