anmolbabu has posted comments on this change. Change subject: engine : VDS Command to start geo-rep session ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/32536/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 299: StartRemoveGlusterVolumeBricks(1422, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 300: StopRemoveGlusterVolumeBricks(1423, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 301: CommitRemoveGlusterVolumeBricks(1424, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 302: RefreshGlusterVolumeDetails(1425, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 303: GlusterVolumeGeoRepStart(1426, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), > This file should be part of the bll patch for start geo-rep Done Line 304: Line 305: // Cluster Policy Line 306: AddClusterPolicy(1450, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 307: EditClusterPolicy(1451, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), http://gerrit.ovirt.org/#/c/32536/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 87: VAR__ACTION__HOT_UNPLUG, Line 88: VAR__ACTION__LOGON, Line 89: VAR__ACTION__LOGOFF, Line 90: VAR__ACTION__REBALANCE_START, Line 91: VAR_ACTION_GEO_REP_START, > part of bll patch Done Line 92: VAR__ACTION__REBALANCE_STOP, Line 93: VAR__ACTION__REMOVE_BRICKS_START, Line 94: VAR__ACTION__ASSIGN, Line 95: VAR__ACTION__START_PROFILE, http://gerrit.ovirt.org/#/c/32536/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionStartVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionStartVDSParameters.java: Line 1: package org.ovirt.engine.core.common.vdscommands.gluster; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class GlusterVolumeGeoRepSessionStartVDSParameters extends GlusterVolumeVDSParameters { > Can you not use GlusterVolumeGeoRepSessionVDSParameters ? (part of status/s Done Line 6: private String slaveVolumeName; Line 7: private String slaveHost; Line 8: private boolean force; Line 9: http://gerrit.ovirt.org/#/c/32536/2/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties: Line 335: AddBricksToGlusterVolumeFailed=Gluster Volume Add Brick(s) Failed. Line 336: GlusterVolumeSetOptionFailed=Gluster Volume Set Option Failed Line 337: GlusterVolumeRebalanceStartFailed=Gluster Volume Rebalance Start Failed Line 338: GlusterVolumeRebalanceStopFailed=Gluster Volume Rebalance Stop Failed Line 339: GlusterVolumeGeoRepStartFailedException=Volume geo-replication start failed > Failed to start geo-replication session for volume? Done Line 340: GlusterVolumeDeleteFailed=Gluster Volume Delete Failed Line 341: GlusterVolumeReplaceBrickStartFailed=Gluster Volume Replace Brick Start Failed Line 342: GlusterVolumeListFailed=Failed to fetch Gluster Volume List Line 343: GlusterVolumeOptionInfoFailed=Failed to fetch Gluster Volume Option Info -- To view, visit http://gerrit.ovirt.org/32536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb18e64dfcf66d61361f958ded9824213e9847a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
