Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin, branding: fix PatternFly impl for IE8 ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/34524/2/backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java File backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java: Line 43: @Test Line 44: public void testGetThemeStyleSheet() { Line 45: assertEquals("User portal style sheet: 'user_portal.css'", "user_portal.css", //$NON-NLS-1$ //$NON-NLS-2$ Line 46: testTheme.getThemeStylesheets("userportal").get(0)); Line 47: assertEquals("User portal style sheet: 'user_portal.css'", "abc.css", //$NON-NLS-1$ //$NON-NLS-2$ > Should the failure message no be: Done Line 48: testTheme.getThemeStylesheets("userportal").get(1)); Line 49: Line 50: assertEquals("Wedadmin style sheet: 'web_admin.css'", "web_admin.css", //$NON-NLS-1$ //$NON-NLS-2$ Line 51: testTheme.getThemeStylesheets("webadmin").get(0)); Line 48: testTheme.getThemeStylesheets("userportal").get(1)); Line 49: Line 50: assertEquals("Wedadmin style sheet: 'web_admin.css'", "web_admin.css", //$NON-NLS-1$ //$NON-NLS-2$ Line 51: testTheme.getThemeStylesheets("webadmin").get(0)); Line 52: assertEquals("Wedadmin style sheet: 'web_admin.css'", "123.css", //$NON-NLS-1$ //$NON-NLS-2$ > Should the failure message no be: Done Line 53: testTheme.getThemeStylesheets("webadmin").get(1)); Line 54: } Line 55: Line 56: @Test -- To view, visit http://gerrit.ovirt.org/34524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b40eef0a1dbdab93d55ab5ea6c25bb9e70714c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
