Omer Frenkel has posted comments on this change.

Change subject: engine: Change DisplayType semantics
......................................................................


Patch Set 27:

(1 comment)

http://gerrit.ovirt.org/#/c/30837/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java:

Line 140: 
Line 141:         createVmParams.getVm().setVmInit(getParameters().getVmInit());
Line 142: 
Line 143:         for (GraphicsType graphicsType : 
getParameters().getRunOnceGraphics()) {
Line 144:             getVm().getGraphicsInfos().put(graphicsType, new 
GraphicsInfo());
> when VM is stopped, graphicsInfos should be empty map - it contains dynamic
ok, just make sure that if user is doing run-once and doesnt change anything, 
the config from the db is used
Line 145:         }
Line 146: 
Line 147:         return createVmParams;
Line 148:     }


-- 
To view, visit http://gerrit.ovirt.org/30837
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0907c9086f49f909250d9956356a0251954f1427
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to