Kanagaraj M has posted comments on this change. Change subject: engine: Geo-rep monitoring ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/31976/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java: Line 104: } Line 105: Line 106: private void removeDeletedSessions(Guid clusterId, final Map<String, GlusterGeoRepSession> sessionsMap) { Line 107: List<GlusterGeoRepSession> sessionsInDb = getGeoRepDao().getGeoRepSessionsInCluster(clusterId); Line 108: if (sessionsInDb == null) { || sessionsInDb.isEmpty() Line 109: return; Line 110: } Line 111: List<GlusterGeoRepSession> sessionsToDelete = new ArrayList<>(); Line 112: for (GlusterGeoRepSession grepSession: sessionsInDb) { Line 150: HashMap<Guid, GeoRepSessionStatus> subVolumeStatusMap = new HashMap<>(); Line 151: int j = 0; Line 152: while (j < replicaCount) { Line 153: Guid brickId = volume.getBricks().get(i + j).getId(); Line 154: subVolumeStatusMap.put(brickId, getStatusForBrickFromSession(session, brickId)); I don't see this brickId getting used below. Can "HashSet<GeoRepSessionStatus> statusValues" be formed here itself? Line 155: j++; Line 156: } Line 157: list.add(subVolumeStatusMap); Line 158: } -- To view, visit http://gerrit.ovirt.org/31976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3304addda17cf49eee93f311e043b0e15212cd91 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
