Sahina Bose has posted comments on this change. Change subject: bll: stop and delete geo-rep session ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33038/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandBase.java: Line 53: return geoRepSession; Line 54: } Line 55: Line 56: @Override Line 57: protected Map<String, Pair<String, String>> getExclusiveLocks() { > It get lock on the georep session in one case. But in else case, it will ge no..super.getExclusiveLocks is not required. Will change that Line 58: if (!isInternalExecution()) { Line 59: return Collections.singletonMap(getGeoRepSession().getId().toString(), Line 60: LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER_GEOREP, VdcBllMessages.ACTION_TYPE_FAILED_GEOREP_SESSION_LOCKED)); Line 61: } -- To view, visit http://gerrit.ovirt.org/33038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537a11bde7c412599a00269d44764f554bb4618d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
