Omer Frenkel has posted comments on this change. Change subject: core: disable the mixing of RHEL6 and RHEL7 in one cluster ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34411/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java: Line 70: Line 71: Line 72: vds.setStatus(VDSStatus.NonOperational); Line 73: } Line 74: if (vds.getStatus() != VDSStatus.NonOperational) { might worth checking hostOs != null Line 75: String[] hostOsInfo = vds.getHostOs().split("-"); Line 76: String osName = hostOsInfo[0].trim(); Line 77: String newVersion = hostOsInfo[1].trim(); Line 78: if (osName.equals("RHEL")) { -- To view, visit http://gerrit.ovirt.org/34411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb6d41b1921a6caf946cba44a6c92ef86fef6bc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
