Sahina Bose has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/33845/6/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetEligibleVolumesForGeoRepEnablingQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetEligibleVolumesForGeoRepEnablingQueryTest.java: Line 79: cluster1.setStoragePoolId(DC_1); Line 80: cluster1.setGlusterService(false); Line 81: cluster1.setId(CLUSTER_ID_1); Line 82: cluster1.setcompatibility_version(new Version("3.4")); Line 83: clusters.add(cluster1); you could refactor getMasterVDS to take parameters to avoid repeating code here Line 84: Line 85: clusters.add(getMasterVds()); Line 86: Line 87: VDSGroup cluster3 = new VDSGroup(); Line 153: doReturn(getGlusterVolume(VOLUME_ID_1, CLUSTER_ID_1, GlusterStatus.UP, new GlusterVolumeSizeInfo(10000L, 6000L, 4000L))).when(volumeDao).getById(VOLUME_ID_1); Line 154: doReturn(getGlusterVolume(VOLUME_ID_2, CLUSTER_ID_2, GlusterStatus.UP, new GlusterVolumeSizeInfo(10000L, 10000L, 0L))).when(volumeDao).getById(VOLUME_ID_2); Line 155: doReturn(getGlusterVolume(VOLUME_ID_3, MASTER_CLUSTER_ID, GlusterStatus.UP, new GlusterVolumeSizeInfo())).when(volumeDao).getById(VOLUME_ID_3); Line 156: doReturn(getGlusterVolume(VOLUME_ID_4, CLUSTER_ID_1, GlusterStatus.UP, new GlusterVolumeSizeInfo(10000L, 10000L, 0L))).when(volumeDao).getById(VOLUME_ID_4); Line 157: doReturn(getGlusterVolume(VOLUME_ID_5, CLUSTER_ID_2, GlusterStatus.UP, new GlusterVolumeSizeInfo(10000L, 10000L, 0L))).when(volumeDao).getById(VOLUME_ID_5); Do you need to add a test where volumeAdvancedDetails is null for a volume? Line 158: Line 159: doReturn(getFirstClusterVolumes()).when(volumeDao).getByClusterId(CLUSTER_ID_1); Line 160: doReturn(getMasterClusterVolumes()).when(volumeDao).getByClusterId(MASTER_CLUSTER_ID); Line 161: doReturn(getSecondClusterVolumes()).when(volumeDao).getByClusterId(CLUSTER_ID_2); -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
