Gilad Chaplik has posted comments on this change. Change subject: core, engine, webadmin: Consider only online logical CPUs ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33788/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java: Line 171: dedicatedVds.getVdsGroupCompatibilityVersion().compareTo(Version.v3_2) >= 0 && Line 172: dedicatedVds.getOnlineCpus() != null) { Line 173: Line 174: for (Integer pCPU : currPcpus) { Line 175: if (!onlinePcpus.contains(pCPU)) { > should be checked only for 3.5 host? on a second look, this check is skipped if dedicatedVds.getOnlineCpus() is null. the question is if we want to preserve the old behavior in that case. Line 176: // ERROR maps to a non existent or offline pcpu Line 177: return failCanDoAction(VdcBllMessages.VM_PINNING_PCPU_DOES_NOT_EXIST); Line 178: } Line 179: } -- To view, visit http://gerrit.ovirt.org/33788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
