anmolbabu has posted comments on this change. Change subject: engine : Bll command to start geo-rep session ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/32537/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepStartCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepStartCommand.java: Line 21: @Override Line 22: protected void executeCommand() { Line 23: GlusterVolumeGeoRepSessionParameters parameters = getParameters(); Line 24: setGlusterVolumeId(parameters.getVolumeId()); Line 25: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GlusterVolumeGeoRepStart, new GlusterVolumeGeoRepSessionVDSParameters(upServer.getId(), getGlusterVolumeName(), parameters.getSlaveVolumeName(), parameters.getSlaveHost())); > isn't the order to GlusterVolumeGeoRepSessionVDSParameters different - firs Done Line 26: setSucceeded(returnValue.getSucceeded()); Line 27: if(getSucceeded()) { Line 28: getGeoRepSession().setStatus(GeoRepSessionStatus.ACTIVE); Line 29: getGlusterGeoRepDao().updateSession(getGeoRepSession()); Line 38: if (!super.canDoAction()) { Line 39: return false; Line 40: } Line 41: if (getGeoRepSession().getStatus().equals(GeoRepSessionStatus.ACTIVE)) { Line 42: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GEOREP_SESSION_STARTED); > shouldn't this be failCanDoAction(..) Done Line 43: } Line 44: return true; Line 45: } Line 46: http://gerrit.ovirt.org/#/c/32537/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 299: StartRemoveGlusterVolumeBricks(1422, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 300: StopRemoveGlusterVolumeBricks(1423, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 301: CommitRemoveGlusterVolumeBricks(1424, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 302: RefreshGlusterVolumeDetails(1425, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 303: GlusterVolumeGeoRepStart(1428, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), > 1428 after 1425? Why not 1426? Done Line 304: Line 305: // Scheduling Policy Line 306: AddClusterPolicy(1450, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 307: EditClusterPolicy(1451, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 299: StartRemoveGlusterVolumeBricks(1422, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 300: StopRemoveGlusterVolumeBricks(1423, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 301: CommitRemoveGlusterVolumeBricks(1424, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 302: RefreshGlusterVolumeDetails(1425, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 303: GlusterVolumeGeoRepStart(1428, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), > Also, verb first in the action name according to convention Done Line 304: Line 305: // Scheduling Policy Line 306: AddClusterPolicy(1450, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 307: EditClusterPolicy(1451, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), -- To view, visit http://gerrit.ovirt.org/32537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib74c515d23218bb2e30403e0e0042c84b74dc2bb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
