Tomer Saban has posted comments on this change. Change subject: webadmin: Fixed VM moving between clusters error. ......................................................................
Patch Set 1: (6 comments) Fixed on next patch http://gerrit.ovirt.org/#/c/34395/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1162: ACTION_TYPE_FAILED_PROFILE_IN_USE=Cannot ${action} ${type}. Profile is in use. Line 1163: ACTION_TYPE_FAILED_DISK_PROFILE_NOT_FOUND=Cannot ${action} ${type}. Disk Profile wasn't found. Line 1164: ACTION_TYPE_DISK_PROFILE_STORAGE_DOMAIN_NOT_PROVIDED=Cannot ${action} ${type}. Storage Domain wasn't provided. Line 1165: ACTION_TYPE_DISK_PROFILE_NOT_MATCH_STORAGE_DOMAIN=Cannot ${action} ${type}. Disk Profile doesn't match provided Storage Domain. Line 1166: ACTION_TYPE_CPU_PROFILE_NOT_MATCH_CLUSTER=Cannot ${action} ${type}. Disk Profile doesn't match provided Cluster. > s/Disk Profile/CPU profile Done Line 1167: ACTION_TYPE_CANNOT_REMOVE_LAST_CPU_PROFILE_IN_CLUSTER=Cannot ${action} ${type}. Cannot remove last CPU profile in Cluster. Line 1168: ACTION_TYPE_CANNOT_REMOVE_LAST_DISK_PROFILE_IN_STORAGE_DOMAIN=Cannot ${action} ${type}. Cannot remove last Disk profile in Storage Domain. Line 1169: Line 1170: # cluster policy errors http://gerrit.ovirt.org/#/c/34395/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3139: Line 3140: @DefaultStringValue("Cannot ${action} ${type}. Disk Profile doesn't match provided Storage Domain.") Line 3141: String ACTION_TYPE_DISK_PROFILE_NOT_MATCH_STORAGE_DOMAIN(); Line 3142: Line 3143: @DefaultStringValue("Cannot ${action} ${type}. Disk Profile doesn't match provided Cluster.") > s/Disk Profile/CPU profile Done Line 3144: String ACTION_TYPE_CPU_PROFILE_NOT_MATCH_CLUSTER(); Line 3145: Line 3146: @DefaultStringValue("Cannot ${action} ${type}. Cannot remove last CPU profile in Cluster.") Line 3147: String ACTION_TYPE_CANNOT_REMOVE_LAST_CPU_PROFILE_IN_CLUSTER(); Line 3141: String ACTION_TYPE_DISK_PROFILE_NOT_MATCH_STORAGE_DOMAIN(); Line 3142: Line 3143: @DefaultStringValue("Cannot ${action} ${type}. Disk Profile doesn't match provided Cluster.") Line 3144: String ACTION_TYPE_CPU_PROFILE_NOT_MATCH_CLUSTER(); Line 3145: > please remove the blanks Done Line 3146: @DefaultStringValue("Cannot ${action} ${type}. Cannot remove last CPU profile in Cluster.") Line 3147: String ACTION_TYPE_CANNOT_REMOVE_LAST_CPU_PROFILE_IN_CLUSTER(); Line 3148: Line 3149: @DefaultStringValue("Cannot ${action} ${type}. Cannot remove last Disk profile in Storage Domain.") http://gerrit.ovirt.org/#/c/34395/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 202: new NameAndDescriptionVmBaseToUnitBuilder(), Line 203: new CommentVmBaseToUnitBuilder(), Line 204: new CommonVmBaseToUnitBuilder()); Line 205: } Line 206: > please remove - the checkstyle would kill the build Done Line 207: @Override Line 208: public void dataCenterWithClusterSelectedItemChanged() Line 209: { Line 210: super.dataCenterWithClusterSelectedItemChanged(); Line 208: public void dataCenterWithClusterSelectedItemChanged() Line 209: { Line 210: super.dataCenterWithClusterSelectedItemChanged(); Line 211: if (getModel().getSelectedCluster() != null) Line 212: { > please use the java formatting - put the '{' to the prev line Done Line 213: updateCpuProfile(getModel().getSelectedCluster().getId(), Line 214: getClusterCompatibilityVersion(), Line 215: vm.getCpuProfileId()); Line 216: } http://gerrit.ovirt.org/#/c/34395/1/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1131: ACTION_TYPE_FAILED_PROFILE_IN_USE=Cannot ${action} ${type}. Profile is in use. Line 1132: ACTION_TYPE_FAILED_DISK_PROFILE_NOT_FOUND=Cannot ${action} ${type}. Disk Profile wasn't found. Line 1133: ACTION_TYPE_DISK_PROFILE_STORAGE_DOMAIN_NOT_PROVIDED=Cannot ${action} ${type}. Storage Domain wasn't provided. Line 1134: ACTION_TYPE_DISK_PROFILE_NOT_MATCH_STORAGE_DOMAIN=Cannot ${action} ${type}. Disk Profile doesn't match provided Storage Domain. Line 1135: ACTION_TYPE_DISK_PROFILE_NOT_MATCH_CLUSTER=Cannot ${action} ${type}. Disk Profile doesn't match provided Cluster. > did you meain CPU profile? Done Line 1136: ACTION_TYPE_CANNOT_REMOVE_LAST_CPU_PROFILE_IN_CLUSTER=Cannot ${action} ${type}. Cannot remove last CPU profile in Cluster. Line 1137: ACTION_TYPE_CANNOT_REMOVE_LAST_DISK_PROFILE_IN_STORAGE_DOMAIN=Cannot ${action} ${type}. Cannot remove last Disk profile in Storage Domain. Line 1138: Line 1139: # cluster policy errors -- To view, visit http://gerrit.ovirt.org/34395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ebc94110b94be74b081d92da3e40a1f5bf9239e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
