Omer Frenkel has posted comments on this change. Change subject: engine: Adjust console ticket commands ......................................................................
Patch Set 37: (3 comments) http://gerrit.ovirt.org/#/c/28574/37/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java: Line 45: } Line 46: Line 47: @Override Line 48: public String toString() { Line 49: return String.format("%s, ticket=%s, validTime=%s,m userName=%s, userId=%s", super.toString(), getTicket(), getValidTime(), please also print the new param values Line 50: getUserName(), getUserId()); Line 51: } http://gerrit.ovirt.org/#/c/28574/37/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java: Line 10: Line 11: public class SetVmTicketVDSCommand<P extends SetVmTicketVDSCommandParameters> extends VdsBrokerCommand<P> { Line 12: Line 13: private String connectionAction = "disconnect"; Line 14: private static final Version TICKET_USING_UPDATE_DEVICE = Version.v3_5; // todo configurability could be nice not just nice, a must.. you should use the FeatureSupported class, see comment in an earlier patch also, i think the value should be 3.6? Line 15: Line 16: public SetVmTicketVDSCommand(P parameters) { Line 17: super(parameters, DbFacade.getInstance().getVdsDao().get(parameters.getVdsId())); Line 18: } Line 43: devStruct.put("password", getParameters().getTicket()); Line 44: devStruct.put("ttl", getParameters().getValidTime()); Line 45: devStruct.put("existingConnAction", connectionAction); Line 46: Line 47: status = getBroker().vmUpdateDevice(getParameters().getVmId().toString(), devStruct); i think you need to send the user details as well, not to break the vdsm hook Line 48: } Line 49: Line 50: private void setTicketWithUID() { Line 51: Map<String, String> params = new HashMap<String, String>(); -- To view, visit http://gerrit.ovirt.org/28574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62c9e29349a58156cddba1ca039cf9b7f14e610 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
