Omer Frenkel has posted comments on this change. Change subject: core: vdsm -> engine communication for spicevnc ......................................................................
Patch Set 34: (2 comments) http://gerrit.ovirt.org/#/c/28572/34/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 581: Line 582: // process all vms that powering up. Line 583: for (VmDynamic runningVm : _poweringUpVms) { Line 584: GraphicsInfo spiceInfo = runningVm.getGraphicsInfos().get(GraphicsType.SPICE); Line 585: if (spiceInfo != null) { we cant skip this call if spice info is null for some reason, just send nulls or 0 or something in the port and ip Line 586: ResourceManager Line 587: .getInstance() Line 588: .getEventListener() Line 589: .processOnVmPoweringUp(_vds.getId(), runningVm.getId(), spiceInfo.getIp(), spiceInfo.getPort()); http://gerrit.ovirt.org/#/c/28572/34/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 350: return; Line 351: } Line 352: Line 353: String displayTypeStr = xmlRpcStruct.get(VdsProperties.displayType).toString(); Line 354: DisplayType displayType = DisplayType.valueOf(displayTypeStr); are you sure this is not the line that would throw the exception in case of a bad str? Line 355: Line 356: try { Line 357: vm.setDisplayType(displayType); Line 358: } catch (Exception e2) { -- To view, visit http://gerrit.ovirt.org/28572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb38b68ba5a49238d4f9d9cce8475f6af9180077 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
