Omer Frenkel has posted comments on this change. Change subject: core: engine <-> vdsm part for spicevnc ......................................................................
Patch Set 34: (2 comments) http://gerrit.ovirt.org/#/c/28571/34/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 101: // todo 3.6, or handle this in a different way Line 102: // the problem here is that if we send both graphics as a device and in conf, old vdsm gets confused and tries Line 103: // to create the "unknown" device Line 104: boolean isRunOnce = vm.getGraphicsInfos() != null && !vm.getGraphicsInfos().isEmpty(); Line 105: boolean usesGraphicsAsDevice = Version.v3_5.compareTo(vm.getVdsGroupCompatibilityVersion()) <= 0; please use configuration instead of hard-coding this, look at FeatureSupported class, create a "graphicsDeviceEnabled" method and config values Line 106: Line 107: if (isRunOnce) { Line 108: buildVmGraphicsDevicesRunOnce(vm.getGraphicsInfos(), usesGraphicsAsDevice); Line 109: } else { http://gerrit.ovirt.org/#/c/28571/34/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 57: private VDSGroup vdsGroup; Line 58: Line 59: // legacy Display types Line 60: protected static final String QXL = "qxl"; Line 61: protected static final String VNC = "vnc"; should be in VdsProperties? or maybe in the num Line 62: Line 63: private static class DiskImageByBootAndSnapshotComparator implements Comparator<Disk>, Serializable { Line 64: private static final long serialVersionUID = 4732164571328497830L; Line 65: -- To view, visit http://gerrit.ovirt.org/28571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6eef54aea60e8fcd7f0d255c6cf72205ae45838 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
