Allon Mureinik has posted comments on this change. Change subject: core: Store iSCSI Target Address instead of IP Address in DB ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34412/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java: Line 50: // address[0] is the IP address of the target as returned from VDSM. Line 51: // Since we want to use the original address from the user's input (which can also be a DNS name), Line 52: // and since VDSM always returns the IP address of the target, we don't want to override it Line 53: // by calling con.setconnection(address[0]). Line 54: log.infoFormat("Connection to {0} requested, VDSM returned {1}.", con.getconnection(), address[0]); > Let's wait for the logging changes to be merged, and fix this one according No need to wait, the change was already introduced. just drop 0 and 1. Line 55: Line 56: connections.add(con); Line 57: } Line 58: -- To view, visit http://gerrit.ovirt.org/34412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf6d385606e130f4f529a0b374a9f731310a7f9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
