Amit Aviram has uploaded a new change for review. Change subject: webadmin: Template's empty string as a disk alias UI fix. ......................................................................
webadmin: Template's empty string as a disk alias UI fix. While making a new template based on a VM, providing the template's allocated disks's alias as an empty string is now disabled ALSO BY UI. the user should not be able to create a template with disks that have an empty aliases- this bug has already been fixed at the BACKEND, this current patch prevents the user from giving an empty alias at UI level. Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7 Bug-Url: https://bugzilla.redhat.com/1110304 Signed-off-by: Amit Aviram <aavi...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/34477/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java index 99f673e..0cfb916 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java @@ -319,16 +319,19 @@ return; } + boolean isModelValid = true; for (DiskModel diskModel : getDisks()) { ListModel diskStorageDomains = diskModel.getStorageDomain(); if (!diskStorageDomains.getItems().iterator().hasNext() || diskStorageDomains.getSelectedItem() == null) { diskModel.getStorageDomain().getInvalidityReasons().add( constants.storageDomainMustBeSpecifiedInvalidReason()); diskModel.getStorageDomain().setIsValid(false); - setIsValid(false); + isModelValid = false; } diskModel.getAlias().validateEntity(new IValidation[] { new NotEmptyValidation(), new I18NNameValidation() }); + isModelValid = isModelValid && diskModel.getAlias().getIsValid(); } + setIsValid(isModelValid); } public void setIsVolumeFormatAvailable(boolean isVolumeFormatAvailable) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java index 0bcc3ce..5fc251a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java @@ -2632,7 +2632,9 @@ boolean vmInitIsValid = getVmInitModel().validate(); setValidTab(TabName.FIRST_RUN, vmInitIsValid); - boolean isValid = hwPartValid && vmInitIsValid && allTabsValid(); + boolean diskAliasesValid = getDisksAllocationModel().getIsValid(); + + boolean isValid = hwPartValid && vmInitIsValid && allTabsValid() && diskAliasesValid; getValid().setEntity(isValid); ValidationCompleteEvent.fire(getEventBus(), this); return isValid; -- To view, visit http://gerrit.ovirt.org/34477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
