Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: ignoring case on DB and DB USER names ......................................................................
Patch Set 2: Alon, I perfectly agree with you if we decide to honor the case everywhere, it's not so simple in the opposite case. Ignoring the case on identifier if not quoted is an SQL lexical convention. So if we issue 'create database EngineDB' it will create a database that instead is called 'enginedb'. At that point we should refer to it just as 'enginedb' for any other occasion such as rewriting pg_hba to configure its access or to retrieve the correct log file otherwise we get further issue, but we still have a mixed case string in our environment. So, on my opinion, assuming that we just want to handle lowercase DB names, it's better to store the DB name as a lower case string as soon as possible to avoid any further problem forgetting to add a '.lower()' somewhere else. -- To view, visit http://gerrit.ovirt.org/34444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367e47889b2445d156f85301f6a87f5892bf9012 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
