Tomas Jelinek has posted comments on this change. Change subject: webadmin: 'Comment' property of existing VM pool dialog editable ......................................................................
Patch Set 1: (1 comment) Please pick the "verified" as soon as you have actually tested the patch. http://gerrit.ovirt.org/#/c/34414/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-23 18:06:17 +0200 Line 6: Line 7: webadmin: 'Comment' property of existing VM pool dialog editable Line 8: Line 9: trivial fix please explain the problem and the fix a bit deeper, something like this: " The comment property of the edit pool was not editable. The problem was that the PoolEditPopupWidget.disableAllTabs(); disabled all the widgets and the subsequent PoolEditPopupWidget. enableEditPoolFields(object); did not enable it. Fixed by adding the missing commentEditor.setEnabled(true); to enableEditPoolFields " This way if someone will try to find out why this line has been added the commit message will help him to understand your reasoning. Line 10: Line 11: Change-Id: I9fe10ea813636a271e1663009d24b6def0072939 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013699 -- To view, visit http://gerrit.ovirt.org/34414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe10ea813636a271e1663009d24b6def0072939 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
