Simone Tiraboschi has uploaded a new change for review.

Change subject: packaging: setup: fixing development environment
......................................................................

packaging: setup: fixing development environment

Fixing imports and external tool usage for
notroot developing environment.

Change-Id: Ifa388eeec683ec2ec4f7e3b3949e296f2078180e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109326
Signed-off-by: Simone Tiraboschi <stira...@redhat.com>
(cherry picked from commit 4a1dbc0343b3d2501dce756df827b5083b78cae1)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
1 file changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/34441/1

diff --git 
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
index 3803f1f..e81250c 100644
--- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
+++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
@@ -88,18 +88,25 @@
         self._foundpreextnfs = False
 
     @plugin.event(
+        stage=plugin.Stages.STAGE_SETUP,
+    )
+    def _setup(self):
+        self._enabled = not self.environment[
+            osetupcons.CoreEnv.DEVELOPER_MODE
+        ]
+
+    @plugin.event(
         stage=plugin.Stages.STAGE_PROGRAMS,
+        condition=lambda self: self._enabled,
     )
     def _programs(self):
         self.command.detect('exportfs')
 
     @plugin.event(
         stage=plugin.Stages.STAGE_LATE_SETUP,
+        condition=lambda self: self._enabled,
     )
-    def _setup(self):
-        self._enabled = not self.environment[
-            osetupcons.CoreEnv.DEVELOPER_MODE
-        ]
+    def _late_setup(self):
         if self._distribution not in ('redhat', 'fedora', 'centos'):
             self.logger.warning(
                 _('Unsupported distribution disabling nfs export')


-- 
To view, visit http://gerrit.ovirt.org/34441
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa388eeec683ec2ec4f7e3b3949e296f2078180e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to