Tomas Jelinek has posted comments on this change. Change subject: webadmin: allow migration to different cluster ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/34347/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java: Line 242: Line 243: Guid run_on_vds = null; Line 244: boolean allRunOnSameVds = true; Line 245: Line 246: for (Object item : selectedVms) > should be formatted (as it's new code...) well, new code... Just moved here from VmListModel :) But ok, lets take this opportunity clean it up a bit - DONE Line 247: { Line 248: VM a = (VM) item; Line 249: if (!a.getVdsGroupId().equals((selectedVms.get(0)).getVdsGroupId())) Line 250: { Line 244: boolean allRunOnSameVds = true; Line 245: Line 246: for (Object item : selectedVms) Line 247: { Line 248: VM a = (VM) item; > rename 'a'.. Done Line 249: if (!a.getVdsGroupId().equals((selectedVms.get(0)).getVdsGroupId())) Line 250: { Line 251: setVmsOnSameCluster(false); Line 252: } Line 264: Line 265: if (getVmsOnSameCluster() && allRunOnSameVds) Line 266: { Line 267: VDS runOnSameVDS = null; Line 268: for (VDS host : hosts) > suggestion, extract to a simple utility just for better clarity Done Line 269: { Line 270: if (host.getId().equals(run_on_vds)) Line 271: { Line 272: runOnSameVDS = host; http://gerrit.ovirt.org/#/c/34347/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.java: Line 71: Line 72: @UiField(provided = true) Line 73: @Path(value = "clusters.selectedItem") Line 74: @WithElementId("clusters") Line 75: public ListModelListBoxEditor<VDSGroup> clusters; > rename to 'clustersEditor' to keep the convention Done Line 76: Line 77: private final Driver driver = GWT.create(Driver.class); Line 78: Line 79: @Inject -- To view, visit http://gerrit.ovirt.org/34347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I224ac719d16b348bb8ea31b256fe459bc372a88d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
