Martin Betak has posted comments on this change. Change subject: webadmin: syntax sugar, simplified popup definition syntax ......................................................................
Patch Set 6: Simplified the Rule infrastructure. Now there is only one hierarchy to maintain. The polymorphism is achieved using generics in the returned Widget type. Also utilized this sugar to refactor VirtualMachineModule -> added needed UICommandNameRule. In this module I used double-brace initializers to configure the MainTabModelProviders (sometimes it was necessary to subclass them anyway). Stylistic comments on this approach are welcome. -- To view, visit http://gerrit.ovirt.org/33942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d2a31583b16a70fb4763a0915a2641ebda9e1e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
