Doron Fediuck has posted comments on this change. Change subject: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/MinaInstallWrapper.java Line 292: "root", I know we had it in the past..... But let's stop hard-coding root. We really wish to use something else one sweet day... Can you either make it a constant (above) or better- take it from vdc_options (config)? -- To view, visit http://gerrit.ovirt.org/6881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba4357fe1b30fc3257b5b5505c9649407c1938ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
