Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: add support for the new management field in save&update ......................................................................
Patch Set 7: (2 comments) the patch is merged into http://gerrit.ovirt.org/#/c/32781 as Alona proposed http://gerrit.ovirt.org/#/c/33499/7/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java: Line 46: Line 47: existingNetworkCluster = dao.getAll().get(0); Line 48: } Line 49: Line 50: private void createNewCluster() { > Maybe createNewNetworkCluster? Done Line 51: newNetworkCluster = new NetworkCluster(); Line 52: newNetworkCluster.setNetworkId(networkNoCluster.getId()); Line 53: newNetworkCluster.setClusterId(freeCluster.getId()); Line 54: newNetworkCluster.setStatus(NetworkStatus.OPERATIONAL); http://gerrit.ovirt.org/#/c/33499/7/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 959: is_display = v_is_display, Line 960: required = v_required, Line 961: migration = v_migration, Line 962: management = v_management Line 963: WHERE cluster_id = v_cluster_id > Please remove the trailing whitespace. Done Line 964: AND network_id = v_network_id; Line 965: END; $procedure$ Line 966: LANGUAGE plpgsql; Line 967: -- To view, visit http://gerrit.ovirt.org/33499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c5ee2075fa593e7d3f96694dce8cd896b4eb449 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
