Tomas Jelinek has posted comments on this change. Change subject: core: medium Instance Type mismatch feature page ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33459/3/packaging/dbscripts/upgrade/03_06_0430_medium_instance_type_has_two_cpus.sql File packaging/dbscripts/upgrade/03_06_0430_medium_instance_type_has_two_cpus.sql: Line 5: Line 6: -- update the VMs based on that instance type Line 7: update vm_static set num_of_sockets = 2 where instance_type_id in (select * from medium_instance_type_id); Line 8: Line 9: drop table medium_instance_type_id; > all of the above IMO can be done w/o temp table by : sure, but in that case: 1: I have to copy paste the whole inner select two times 2: the " where instance_type_id in (select * from medium_instance_type_id)" is more readable than " where instance_type_id in ( select vm_guid from vm_static where entity_type = 'INSTANCE_TYPE' and vm_name = 'Medium' and description = 'Medium instance type' and mem_size_mb = 4096 and num_of_sockets = 1 and cpu_per_socket = 1) " or is it only my java soul speaking? :) -- To view, visit http://gerrit.ovirt.org/33459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03407f86c272578cec671f49e89d2ffbeb93ae4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
