Tomas Jelinek has uploaded a new change for review.

Change subject: engine: It is not possible to take prestared VM from pool 
(#844917)
......................................................................

engine: It is not possible to take prestared VM from pool (#844917)

https://bugzilla.redhat.com/844917

The problem was in AttachUserToVmFromPoolAndRunCommand
which set the "returnValue" and "succeeded" only after
the VM has been started - so ignoring the pre-stared VMs.

It is safe to set the succeeded to true in that else block
because if any error occures, the method returns earlier.

Change-Id: I2e4075119516a1447bf3036e6bdddc56abf9ad39
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/6868/1
--
To view, visit http://gerrit.ovirt.org/6868
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e4075119516a1447bf3036e6bdddc56abf9ad39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to