Sahina Bose has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll/gluster ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Minor comment inline http://gerrit.ovirt.org/#/c/34323/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 568: if (!idsToRemove.isEmpty()) { Line 569: try { Line 570: getBrickDao().removeAll(idsToRemove); Line 571: } catch (Exception e) { Line 572: log.error("Error while removing bricks from database!", e); log.debug("Exception",e) ? Line 573: } Line 574: } Line 575: } Line 576: -- To view, visit http://gerrit.ovirt.org/34323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f5419168ce6b26c110839dcd85cac995e5aa5db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
