Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: lazy load list models ......................................................................
Patch Set 4: You should be able to log in again. There were several issues: 1. There was a stray private eventbus that wasn't getting injected since it should be there, I removed it. 2. The SharedMacPoolListModel wasn't being managed by gin (I believe it is a main model so should be managed by gin). 3. You overrode getModel in MacPoolPermissionModelProvider with a version that would get a manually instantiated permissionmodel which would have null event bus. This version will let you log in again, but it seems there is an issue with the VM cell table unrelated to this patch. -- To view, visit http://gerrit.ovirt.org/34193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a2f8915203f4a2b9868767419351ef7ac702891 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
