Alon Bar-Lev has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll/XXX ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/34325/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java: Line 221: } Line 222: } Line 223: } catch (Exception e) { Line 224: log.error("Exception during process of events for pool '{}'", storagePoolId); Line 225: log.error("Exception", e); this is classic of not needing stack trace in log, there was no before, no reason for it be after in error level. Line 226: } Line 227: } Line 228: } Line 229: } -- To view, visit http://gerrit.ovirt.org/34325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I564678b8226542a4900450f8a0e5aa0c7249df70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
